Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify project statuses to handle Verified & GIVbacks Eligible #1743

Closed
divine-comedian opened this issue Jul 31, 2024 · 2 comments
Closed
Assignees
Labels
DeVerification Decentralizing Project Verification

Comments

@divine-comedian
Copy link
Collaborator

divine-comedian commented Jul 31, 2024

With this new feature the current "Verified" project status will be modified and a new status of GIVbacks eligible will be introduced.

Verified

Projects can become Verified by receiving the required amount of vouches through DeVouch - handled by #1740

Verified projects have less benefits than GIVbacks Eligible projects, they are:

  • can be boosted by GIVpower
  • is affected by instant boosting (shows higher up on list of projects when sorted by GIVpower)

GIVbacks Eligible

Projects can become GIVbacks Eligible by following the current Project Verification process.

  • Project fills out "verification form"
  • Admin either approves or rejects application
  • on approval from admin project receives status of GIVbacks Eligible

Image


What we'll need ASAP @MohammadPCh is the ability to change project's status to either of these new statuses at least from the admin panel and be able to apply the corresponding benefits as described above for Verified & GIVbacks Eligible.

for testing

making a project "vouched" status

  • go to admin panel
  • select under "Project" tab and choose a project to make vouched
  • click verify button
    Image
  • project should be able to be boosted with GIVpower
  • donations to this project SHOULD NOT be eligible for GIVbacks
  • check eligible donations response using https://givback.develop.giveth.io/api-docs/
  • donation to project that is only vouched should not show up

making a project GIVbacks Eligible

  • check if project has submitted "GIVbacks Eligiblity" form (formerly verification form)
  • go to admin panel, "Project Verification Form" tab
  • find application form from given project
  • press approve project button
    Image
  • this project should be able to be boosted with GIVpower
  • donations to this project should be eligible for GIVbacks
  • check eligible donations response using https://givback.develop.giveth.io/api-docs/
  • donation to this project that is GIVbacks eligible should show up in response
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Aug 2, 2024
@divine-comedian divine-comedian moved this from New Issues to Product Backlog in Decentralized Verification Aug 13, 2024
@divine-comedian divine-comedian moved this from New Issues to Product Backlog in All-Devs Aug 13, 2024
@divine-comedian divine-comedian moved this from Product Backlog to In Progress in Decentralized Verification Aug 20, 2024
@divine-comedian divine-comedian moved this from Product Backlog to In Progress in All-Devs Aug 20, 2024
@divine-comedian
Copy link
Collaborator Author

Mohammad said to wait to merge - we need to figure out givbacks-calculation issue before we can merge it

@divine-comedian divine-comedian moved this from In Progress to Code Review/PR in All-Devs Aug 27, 2024
@divine-comedian divine-comedian moved this from In Progress to Code Review/PR in Decentralized Verification Aug 27, 2024
@divine-comedian divine-comedian added the DeVerification Decentralizing Project Verification label Sep 5, 2024
@divine-comedian divine-comedian moved this from Code Review/PR to QA in Decentralized Verification Sep 17, 2024
@divine-comedian divine-comedian moved this from Code Review/PR to QA in All-Devs Sep 18, 2024
@LatifatAbdullahi
Copy link

@MohammadPCh @divine-comedian

Test Update

Vouched Project

  • Project should be able to be boosted with GIVpower - Pass
  • Donations to this project SHOULD NOT be eligible for GIVbacks - Pass
  • Donation to project that is only vouched should not show up - Pass

GIVback Eligible Projects

  • This project should be able to be boosted with GIVpower - Pass
  • Donations to this project should be eligible for GIVbacks - Pass
  • Donation to this project that is GIVbacks eligible should show up in response - Pass

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Sep 24, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in All-Devs Oct 4, 2024
@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Oct 4, 2024
@divine-comedian divine-comedian moved this from Done to Merged to Production in Decentralized Verification Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in Decentralized Verification Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeVerification Decentralizing Project Verification
Projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants