-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent duplicate tokens being added in adminJS #1777
Comments
@RamRamez have you had a chance to investigate this issue? |
@maryjaf please test and verify. Users shouldn't be able to add a token when:
(FYI We have a full page error for these scenarios and I couldn't customize the error page in adminjs) |
but when I try to add token with address that is already exist on our db I got below error |
@maryjaf those tokens you added are on different chains. This was scenario: The error you showed is ok. |
|
now the Acs have bben passed . |
On a few different occasions now we have had instances of donations going missing because of duplicate tokens being added to the adminJS. We should create some checks and error conditions to prevent this from recurring.
We should check two conditions when a user is adding a new token for a given network and throw an error if true
the error thrown should be descriptive depending on the condition that triggers it
The text was updated successfully, but these errors were encountered: