-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust givbacks factors for verified vs. givbacks eligible #1798
Comments
@MohammadPCh Has separated Givback Eligible and *verified in this PR #1770 And for this phase we can't separate ranking for verified and givback eligible projects, for that purpose we need to create a new materialized view , ... @divine-comedian Should we hold on and don't merge that PR till implement this issue or we can merge it and for second phase we apply these requirements? |
Following up on this in our convo - we need to make sure we can handle GIVbacks correctly even for the first phase of this feature. projects that are not givbacks eligible should not receive GIVbacks. We'll need to figure out and estimate the necessary work. |
@mohammadranjbarz what is the update on this issue? |
I made the Pr and @CarlosQ96 approved it, I just didn't merge it to staging because I wanted to do it after the release, if we don't have any release soon, I can merge the PRs |
related to this PR |
@mohammadranjbarz should need to make tiny changes to the givbacks-calculation repo - he says only 1 hour of work let's make sure we get it done! |
@mohammadranjbarz @divine-comedian Test update Vouched status -Donations to this project SHOULD NOT be eligible for GIVbacks - Pass GIVback Eligible status -Donations to this project should be eligible for GIVbacks - Pending GIVback Factor
Whilst testing the eligibledonation API the whole page went blank showing this error |
It's up and running now, can you test it again? |
@mohammadranjbarz @divine-comedian Test update Vouched status -Donations to this project SHOULD NOT be eligible for GIVbacks - Pass GIVback Eligible status -Donations to this project should be eligible for GIVbacks - Pass GIVback Factor Check top ranked project that is GIVbacks eligible yields 80% GIVbacks factor to donors - Pass |
With the coming changes of Decentralized Verification we will have two tiers of "verification" statuses.
verified
andgivbacksEligible
.verified
projects can participate in GIVpower, have a rank, but DO NOT yield GIVbacks to their donorsgivbacksEligible
projects have GIVpower and yield GIVbacks to their donors.we will need to be able to make the changes to our givbacks calculations in order to handle this change.
As an example, ff we have 100 projects total that have the statuses GIVbacks Eligible and Verified, then we would handle GIVbacks like below:
As you can see verified projects can potentially have a higher rank than
givbacksEligible
projects, however we should not consider them when calculating the givbacks factor. When calculating the givbacks factor we skip over the notgivbacksEligible
projects and only consider the nextgivbacksEligible
projects as if it were the next lowest rank project.additionally we should ensure project data that shows the predicted givbacks factor are showing the correct percentages @MohammadPCh
for testing
making a project "vouched" status
making a project GIVbacks Eligible
checking GIVbacks factor
the top ranked project yields 80% givbacks factor
bottom ranked project yields 50% givbacks factor
the difference between the top and bottom rank givbacks factor is 30% (50-80)
so for example if there are 50 ranked projects that are GIVbacks eligible then
30 / 50 = 0.6 so each project from the top rank down should have 0.6% less GIVbacks factor
The text was updated successfully, but these errors were encountered: