Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update draft donation service to prevent missed donations #1819

Closed
divine-comedian opened this issue Sep 12, 2024 · 6 comments
Closed

update draft donation service to prevent missed donations #1819

divine-comedian opened this issue Sep 12, 2024 · 6 comments
Assignees
@mohammadranjbarz
Labels
bug Something isn't working

Comments

@divine-comedian
Copy link
Collaborator

@mohammadranjbarz from our dev daily call today we should document and track the fixes required in order to prevent the draft donation service from missing donations
@divine-comedian divine-comedian added the bug Something isn't working label Sep 12, 2024
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Sep 12, 2024
@divine-comedian divine-comedian moved this from New Issues to Product Backlog in All-Devs Sep 12, 2024
@divine-comedian divine-comedian moved this from Product Backlog to Dev Research in All-Devs Sep 12, 2024
@mohammadranjbarz
Copy link
Collaborator

A missed donation reported by @laurenluz
https://polygonscan.com/tx/0x4fec9dd3ed1e6c3d4790af4671de9c01def7944116596dfbc0e9d8d60d5eb299

mohammadranjbarz added a commit that referenced this issue Sep 14, 2024
@mohammadranjbarz
Change compare amount logic, in draft donation service
dfa1a7a 
related to #1819 https://github.com/GeneralMagicio/QAcc-BE/blob/809fa8e57f6cc881acfdf0c387a0a0a8ceebaeae/src/services/chains/index.ts#L105
@mohammadranjbarz mohammadranjbarz mentioned this issue Sep 14, 2024
Merged
@divine-comedian
Copy link
Collaborator Author

@mohammadranjbarz are we just missing a PR to solve this issue?

@mohammadranjbarz
Copy link
Collaborator

mohammadranjbarz commented Sep 19, 2024 •
edited
Loading

@mohammadranjbarz are we just missing a PR to solve this issue?

It is is an extra thing that @aminlatifi suggested, without that PR our verification and draft system still works fine

@divine-comedian
Copy link
Collaborator Author

Thanks for the update @mohammadranjbarz is there anything we should do to test this?

@divine-comedian divine-comedian mentioned this issue Sep 19, 2024
Open
@mohammadranjbarz
Copy link
Collaborator

Thanks for the update @mohammadranjbarz is there anything we should do to test this?

No, it's a super rare case, it's hard to test it

@divine-comedian divine-comedian moved this from Dev Research to In Progress in All-Devs Sep 22, 2024
@divine-comedian divine-comedian moved this from In Progress to Code Review/PR in All-Devs Sep 22, 2024
@divine-comedian
Copy link
Collaborator Author

OK! Please update this issue when the PR is merged and we can move it to done.

mohammadranjbarz added a commit that referenced this issue Sep 23, 2024
@mohammadranjbarz
Change compare logic in draft donation service (#1823)
312a395 
* Change compare amount logic, in draft donation service

related to #1819 https://github.com/GeneralMagicio/QAcc-BE/blob/809fa8e57f6cc881acfdf0c387a0a0a8ceebaeae/src/services/chains/index.ts#L105

* Fix test cases
@divine-comedian divine-comedian moved this from Code Review/PR to Done in All-Devs Sep 23, 2024
@divine-comedian divine-comedian closed this as completed by moving to Merged to Production in All-Devs Oct 3, 2024
@github-project-automation github-project-automation bot moved this from Merged to Production to Done in All-Devs Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohammadranjbarz mohammadranjbarz

Labels
bug Something isn't working
Projects
All-Devs
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohammadranjbarz @divine-comedian