Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Goldsrc Servers support #5

Open
LAxBANDA opened this issue Nov 3, 2022 · 3 comments
Open

Enable Goldsrc Servers support #5

LAxBANDA opened this issue Nov 3, 2022 · 3 comments

Comments

@LAxBANDA
Copy link

LAxBANDA commented Nov 3, 2022

This package only supports response for Source servers, I have made changes to make it compatible with Goldsrc servers (Counter Strike 1.6, Half-Life, Team Fortress Classic, etc)

Steam documentation taught me how to validate this.
For more information: https://developer.valvesoftware.com/wiki/Server_queries

It must be discriminated in the _parseInfoBuffer function in position [4] of the buffer and determine if it is "m" or "I"

I have changes ready to propose, I hope you can give me access to contribute to the project

@GiyoMoon
Copy link
Owner

GiyoMoon commented Nov 4, 2022

Hey! Many thanks for you efforts :) Feel free to open a pull request with the changes and I'll have a look if it fits to the package.

@LAxBANDA
Copy link
Author

LAxBANDA commented Nov 4, 2022

I made a pr witht changes. Thanks

@LAxBANDA
Copy link
Author

LAxBANDA commented Nov 7, 2022

Hi, can review the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants