Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving development of message* modules back to drupal.org #247

Open
jhedstrom opened this issue Mar 18, 2019 · 3 comments
Open

Comments

@jhedstrom
Copy link
Collaborator

Now that drupal.org has really good testing infra targeted at Drupal modules, it would be nice to move the message stack back there for development. An added bonus would be author/contributor attribution credit with commits.

We'd also benefit from the nightly builds there which would let us know sooner rather than later when a breaking change is introduced in core.

@amitaibu
Copy link
Member

I'm fine with that in general, but maybe we should wait for the PR to land there? The move to GitHub wasn't ideology, it was just the lack of convenient tools.

We'd also benefit from the nightly builds there which would let us know sooner rather than later when a breaking change is introduced in core.

Travis has a "cron" feature for that as-well.

Anyway, @jhedstrom since you are doing all the hard work - it's your call :)

@jhedstrom
Copy link
Collaborator Author

My main thinking for moving back were these two issues:

  • We spend a ton of effort mimicking Drupal CI via Travis.
  • The attribution credits actually encourages contributions since they play into this listing.

I do like PRs, but one benefit of the patch system is that anybody can pick up and work on an abandoned patch, while re-working a PR in such a way that both authors get commit credit requires the new participant to know how to merge their branch, etc.

@amitaibu
Copy link
Member

👍 I'm ok with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants