Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsample_array still runs random subsampling with subsample=1 #504

Closed
rhugonnet opened this issue Mar 8, 2024 · 0 comments · Fixed by #501
Closed

subsample_array still runs random subsampling with subsample=1 #504

rhugonnet opened this issue Mar 8, 2024 · 0 comments · Fixed by #501
Labels
bug Something isn't working performance Related to computational performance

Comments

@rhugonnet
Copy link
Member

Effectively "shuffles" the dataset, I think it is better to skip the subsampling entirely... Especially for testing purposes.

Ongoing in #501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working performance Related to computational performance
Projects
None yet
Milestone
No milestone
1 participant
@rhugonnet