Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent sign of translations in AffineCoreg methods since restructuration #586

Closed
rhugonnet opened this issue Sep 10, 2024 · 0 comments · Fixed by #585
Closed

Inconsistent sign of translations in AffineCoreg methods since restructuration #586

rhugonnet opened this issue Sep 10, 2024 · 0 comments · Fixed by #585
Labels
bug Something isn't working priority Needs to be fixed rapidly

Comments

@rhugonnet
Copy link
Member

Due to old code being inconsistent in _apply_rst and _to_matrix_func of AffineCoreg methods, since the #530 restructuration which makes everything use the same apply_matrix function, the direction of a translation is not stored/applied consistently resulting in bugs.

Fixing this in #585 with more rigorous tests...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority Needs to be fixed rapidly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Homogenize sign of translation coregistration and add affine tests rhugonnet/xdem
1 participant
@rhugonnet