Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zigbee2mqtt_smart_doorbell_HEIMAN_HS2DB #2184

Conversation

William-De71
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

https://community.gladysassistant.com/t/bouton-sonnette-heiman-domadoo/9231

@William-De71 William-De71 changed the title add new enum pressed to click button zigbee2mqtt_smart_doorbell_HEIMAN_HS2DB Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (dfff5d2) to head (97e2727).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2184   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         876      876           
  Lines       14409    14420   +11     
=======================================
+ Hits        14198    14209   +11     
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Dec 9, 2024

#2917 Bundle Size — 10.41MiB (~+0.01%).

97e2727(current) vs f85f2bf master#2916(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2917
     Baseline
#2916
Regression  Initial JS 5.64MiB(~+0.01%) 5.64MiB
No change  Initial CSS 304.89KiB 304.89KiB
Change  Cache Invalidation 54.06% 0%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1511 1511
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2917
     Baseline
#2916
Regression  JS 7.43MiB (~+0.01%) 7.43MiB
No change  IMG 2.54MiB 2.54MiB
No change  CSS 321.79KiB 321.79KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.79KiB 17.79KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch William-De71:add_action_smart_do...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 🙏

@Pierre-Gilles Pierre-Gilles merged commit e38bbde into GladysAssistant:master Dec 10, 2024
9 checks passed
@William-De71 William-De71 deleted the add_action_smart_doorbell_button_HEIMAN_HS2DB branch December 10, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants