Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the test env have a jupyter lab? #117

Open
dhruvbalwada opened this issue Apr 25, 2021 · 2 comments
Open

Should the test env have a jupyter lab? #117

dhruvbalwada opened this issue Apr 25, 2021 · 2 comments

Comments

@dhruvbalwada
Copy link
Member

Should the test env that is created from one of the environment files in ci have jupyter lab as a default package?

I am wondering how others about doing any dev after setting up the test env in the step 4 or 5 in the contributing guide? Do you do it in .py scripts?

@jbusecke
Copy link
Contributor

It would definitely bloat the dependecies and thus probably slow down the CI (where it is not needed). I personally usually use one 'main' env that contains jupyterlab and then add ipykernel to all specific envs (more details here).
I think for the sake of simplicity it might be good to add a line on how to install jupyterlab on top of the env to the contributor guide.

@dhruvbalwada
Copy link
Member Author

Thanks. Yeah adding a line on how to do this to contribution guide will help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants