-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with sunrise and sunset calculations #202
Comments
Welcome and thank you for reporting the issue! |
But if you add in the timezone hours, +10h, you would still need to add to both sunrise and sunset and therefore sunrise would still technically be after sunset. I have checked this with the Astral package as well (the original package used in GliderTools for sunrise/sunset calculations) and the issue persists there as well. |
Ah, I see. This means we will need a patch to make GliderTools quenching correction work at your longitudes, preferably directly in our |
I addressed this issue in pull request #204, branch fix_#202. Feel free to use and comment/test. |
There is an issue in the calculation of sunrise and sunset.
For some longitudes >~70E the sunrise is later than sunset.
Example data:
'2021-03-06'
lat = 20.2
lon = 154.7
sunrise = '2021-03-06T19:56:00.000000'
sunset = '2021-03-06T07:47:00.000000'
If we change lon to 65E then there is no issue:
sunrise = '2021-03-06T01:57:00.000000'
sunset = '2021-03-06T13:47:00.000000'
The text was updated successfully, but these errors were encountered: