Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Bottles to remove water source blocks if "remove source blocks" option is enabled #835

Open
MuteTiefling opened this issue Feb 10, 2024 · 2 comments
Labels

Comments

@MuteTiefling
Copy link

Overview

When /gamerule waterSourceConversion false is set (water is not infinite), using a glass bottle or canteen on a source block should consume that block.

Why would this feature be useful?

This would allow further control on water as a limited resource when this gamerule is in use.

@Forstride
Copy link
Member

Forstride commented Feb 11, 2024

There's already a config option for it for canteens. Not sure if we can easily make it work for bottles though.

As for the gamerule, I don't want to tie it to that since it's specifically for the behavior of water, not items that interact with it.

@Forstride Forstride changed the title Bottles and Canteens should consume water source blocks Allow Bottles to remove water source blocks if "remove source blocks" option is enabled Feb 11, 2024
@MuteTiefling
Copy link
Author

Ah cool. Sorry I overlooked the config option.

Full disclosure, I was asking for this because this mod breaks with TAN installed, and it really felt like a feature that makes sense for TAN to do baseline.

https://www.curseforge.com/minecraft/mc-mods/thirsty-bottles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants