Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Support navigation drawer instead of third party #392

Open
emartynov opened this issue Jan 14, 2018 · 9 comments
Open

Use Support navigation drawer instead of third party #392

emartynov opened this issue Jan 14, 2018 · 9 comments

Comments

@emartynov
Copy link
Contributor

I've removed date/time pickers and FAB. But removing drawer requires a bit more time.

@paolorotolo
Copy link
Collaborator

Drawer library isn't deprecated and is well supported. We can keep it IMHO.

@AndyScherzinger
Copy link

AndyScherzinger commented Jan 14, 2018

Both variants seem fine to me. I did the support lib drawer implementation for Nextcloud so that is doable while the lib offers a lot of on top functionality. So both have their upsides.

@emartynov
Copy link
Contributor Author

Up to you. As for me, less third-party dependencies is better.

@AndyScherzinger
Copy link

I’d leave the decision to @paolorotolo

@emartynov
Copy link
Contributor Author

I've asked Mike about it mikepenz/MaterialDrawer#2171

@paolorotolo
Copy link
Collaborator

paolorotolo commented Jan 14, 2018

Yes, I like the idea to reduce the amount of third-party libraries in the app but I also don't want to reinvent the wheel.
I've seen Mike answer and for now our implementation of the drawer is pretty standard and could be replaced by the Support Library without issues.

On another side, we might need to introduce login very soon (to enable @chrispecoraro's API) and add Account support to the drawer, and this is easily achievable with Mike Penz's library.

@emartynov
Copy link
Contributor Author

I'm not sure about login for the user. It doesn't give much additional functionality and only will be added by developers to achieve unique ID for uploaded data. That might be resolved by just GUID generation.

Unless we have something on the roadmap that will also use login.

@paolorotolo
Copy link
Collaborator

No, as @emartynov said we only need login to get an ID for our API.
@bkerensa can say more about our vision, one of the key principles of our project is to keep users in complete control of their data, for this I wouldn't consider for now the option to upload data to third-party servers.

Unless, if we really want to explore the possibility of sync between devices, we can add login to a personal NextCloud server or something like that. But again, we need to discuss this properly and we're going a little OT here.

@piotrek1543
Copy link
Contributor

@emartynov @paolorotolo guys, could you update projects kanban? It looks old and has some issues are closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants