-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Support navigation drawer instead of third party #392
Comments
Drawer library isn't deprecated and is well supported. We can keep it IMHO. |
Both variants seem fine to me. I did the support lib drawer implementation for Nextcloud so that is doable while the lib offers a lot of on top functionality. So both have their upsides. |
Up to you. As for me, less third-party dependencies is better. |
I’d leave the decision to @paolorotolo |
I've asked Mike about it mikepenz/MaterialDrawer#2171 |
Yes, I like the idea to reduce the amount of third-party libraries in the app but I also don't want to reinvent the wheel. On another side, we might need to introduce login very soon (to enable @chrispecoraro's API) and add Account support to the drawer, and this is easily achievable with Mike Penz's library. |
I'm not sure about login for the user. It doesn't give much additional functionality and only will be added by developers to achieve unique ID for uploaded data. That might be resolved by just GUID generation. Unless we have something on the roadmap that will also use login. |
No, as @emartynov said we only need login to get an ID for our API. Unless, if we really want to explore the possibility of sync between devices, we can add login to a personal NextCloud server or something like that. But again, we need to discuss this properly and we're going a little OT here. |
@emartynov @paolorotolo guys, could you update projects kanban? It looks old and has some issues are closed. |
I've removed date/time pickers and FAB. But removing drawer requires a bit more time.
The text was updated successfully, but these errors were encountered: