Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make certificate uploadable instead of text input for SAML IDPs in passport #1716

Open
jgomer2001 opened this issue Jul 10, 2019 · 1 comment
Assignees
Labels
passport Passport related issues
Milestone

Comments

@jgomer2001
Copy link
Contributor

When creating IDPs the certificate is required to be pasted as a single string with header, footer and blanks removed

The form should allow uploading the file or provide a textarea where cert contents can be pasted, then internally do the conversion as necessary.

@jgomer2001 jgomer2001 added duplicate Needs Documentation Issue that requires documentation to be added in Gluu docs Needs screenshot Resolved issue requires a new or updated screenshot for the documentation Needs QA labels Jul 10, 2019
@jgomer2001 jgomer2001 added this to the 4.1 milestone Jul 10, 2019
@aliaksander-samuseu
Copy link
Contributor

aliaksander-samuseu commented Sep 19, 2019

@syntrydy

Just wanted to share my thoughts on this. IMO it should allow both methods (an upload button AND text input field), as different IDPs may make the one or the other approach more convenient (can vary by IDP). Sometimes it's easier to copy-paste it, in other case uploading may be the easiest option.

Just one more thing: I would strongly suggest for the text input field to be able to digest a proper complete X.509 cert (as currently we need to strip BEGIN/END lines first, then turn it into one-liner, what is really cumbersome). As Passport apparently needs it to be a one-liner without those start-end tags, the code behind the field need to do all needed preparations transparently to the user.

@yuriyz yuriyz modified the milestones: 4.1, 4.2 Dec 12, 2019
@nynymike nynymike added passport Passport related issues and removed Needs Documentation Issue that requires documentation to be added in Gluu docs Needs screenshot Resolved issue requires a new or updated screenshot for the documentation Needs QA labels Jan 20, 2020
@syntrydy syntrydy modified the milestones: 4.2, 4.3 May 26, 2020
@syntrydy syntrydy modified the milestones: 4.3, 5.0 Jul 22, 2020
@nynymike nynymike changed the title Make certificate uploadable instead of text input for SAML IPDs in passport Make certificate uploadable instead of text input for SAML IDPs in passport Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
passport Passport related issues
Projects
None yet
Development

No branches or pull requests

5 participants