Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "Claim Celo Domain" shows for wallet with Celo Domain; Celo Domain not displayed #190

Closed
decentralauren opened this issue Feb 14, 2024 · 6 comments
Assignees
Labels
bug Something isn't working P2 - Medium Issues that should be addressed but are not urgent.

Comments

@decentralauren
Copy link

decentralauren commented Feb 14, 2024

Issue

It suggests that I claim my Celo domain, but I already have one in this wallet.
Captura de Pantalla 2024-02-02 a las 19.20.02.png

Wallet address: 0x6823a04a6fd4148167567d5ef6dcca1f34db0494

Fix

  • Implement display of .celo domain name in Wallet Detail / Profile following the below design (Figma here)
  • "Claim your Celo Domain" should not show for wallets that have Celo domain(s)

Screenshot 2024-02-14 at 11.19.54 AM.png

@decentralauren decentralauren added the bug Something isn't working label Feb 14, 2024
@L03TJ3 L03TJ3 transferred this issue from GoodDollar/GoodProtocolUI Mar 20, 2024
@decentralauren
Copy link
Author

We need to investigate the display logic here - I have both a .celo and .eth domain on this wallet however only .eth shows.
Screenshot 2024-04-10 at 6 13 22 PM

@decentralauren decentralauren added the P2 - Medium Issues that should be addressed but are not urgent. label Apr 10, 2024
@L03TJ3 L03TJ3 self-assigned this Jun 26, 2024
@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jun 26, 2024

@decentralauren currently we have hardcoded to only fetch .eth

My action item is: verifying that this flow works for CELO chain.

My question to you is: should we show all names, or just celo related ones?

@decentralauren
Copy link
Author

@L03TJ3 the original requirement was to show the below based on what was have (show the highest priority one available):

  1. Celo domain
  2. Eth Domain (show "claim your celo domain" URL)
  3. wallet address (show "claim your celo domain" URL)

@sirpy
Copy link
Contributor

sirpy commented Oct 6, 2024

celo domains are deprecated, the website to buy them doesnt exists anymore, the company that did them pivoted to AI:)

@sirpy sirpy assigned sirpy and unassigned L03TJ3 Oct 7, 2024
sirpy added a commit that referenced this issue Oct 7, 2024
#191 [Bug] "Claim Celo Domain" shows for wallet with Celo Domain; Celo Domain not displayed #190
@sirpy
Copy link
Contributor

sirpy commented Oct 7, 2024

@decentralauren
see #191 for changes to the profile

@sirpy
Copy link
Contributor

sirpy commented Oct 7, 2024

celo domains no longer relevant

@sirpy sirpy closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 - Medium Issues that should be addressed but are not urgent.
Projects
None yet
Development

No branches or pull requests

3 participants