Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Please see smart contract" Info to have rich description. #209

Open
3 of 5 tasks
sirpy opened this issue Jul 9, 2024 · 5 comments
Open
3 of 5 tasks

Update "Please see smart contract" Info to have rich description. #209

sirpy opened this issue Jul 9, 2024 · 5 comments
Assignees

Comments

@sirpy
Copy link
Contributor

sirpy commented Jul 9, 2024

it is not clear what is the user supposed to see and how he can see that information

image.png

image.png

Edit

  • add the fields rewardDescription + goodidDescription to the app models and data read from ipfs
  • show instead text from the ipfs json field rewardDescription
  • for ubi pool show text from ipfs json field goodidDescription
  • update subgraph to support these fields
  • update demo/helper createpool script/sdk to support fields
@decentralauren
Copy link

@sirpy if you check the Figma, the original intent was for it to display information from the contract which described the payment logic for the activity. See attached.

If necessary we can hard-code this like we do the description.

Screenshot 2024-07-09 at 9 44 47 PM

@sirpy
Copy link
Contributor Author

sirpy commented Jul 14, 2024

@decentralauren
The payments are more complex, since for example for silvi you have payments for different stages of the trees.
Also we dont have the human readable names for the stages. we just have event type 1,2,3 etc...

The options are

  1. remove it
  2. show less friendly data. ie Stewards get 20G$ for event type1
  3. add it as another description field the pool creator needs to fill when creating the pool.

@decentralauren
Copy link

@sirpy Option 3, please.

@decentralauren decentralauren changed the title Info not clear and confusing Update "Please see smart contract" Info to have rich description. Aug 23, 2024
@L03TJ3
Copy link
Collaborator

L03TJ3 commented Sep 19, 2024

@sirpy will you add this field to the settings?

@sirpy
Copy link
Contributor Author

sirpy commented Sep 19, 2024

@L03TJ3 its done. but you will need to update the IPFS data of the pools or create new pools with these fields in their ipfs data

sirpy added a commit that referenced this issue Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants