Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add indication to user when data is loading #211

Closed
2 tasks
sirpy opened this issue Jul 9, 2024 · 7 comments
Closed
2 tasks

add indication to user when data is loading #211

sirpy opened this issue Jul 9, 2024 · 7 comments
Assignees

Comments

@sirpy
Copy link
Contributor

sirpy commented Jul 9, 2024

Sometimes we need to wait before allowing user to perform action.
like in the donate screen, when donating in a non G$ currency, we need to calculate the best uniswap exchnage path,
this takes time, until that time the button should be disabled + some kind of indication to user that he needs to wait.

Currently i've added this indication as a Spinner on the button

Todo:

  • choose color/design for indicator
  • check if loading indication is required in other places

image.png

@decentralauren
Copy link

decentralauren commented Jul 9, 2024

@SanaJamm can you please provide guidance for Hadar? Ideally it matches other patterns / styles elsewhere in GoodCollective, Goodwallet and GoodDapp.

Maybe also see how this is handled in other dapps to find common patterns.

@SanaJamm
Copy link

@sirpy for some reason I can't view the image attached

@sirpy
Copy link
Contributor Author

sirpy commented Jul 14, 2024

@SanaJamm are you logged in to zenhub?

image

@decentralauren
Copy link

@sirpy we would like to follow the same pattern as the Uniswap widget in GoodDapp (see animation below), where loading is handling by a combination of 1) a spinner in the widget which presents the info being updated and 2) a button that goes between disabled and enabled based on ability to perform the transaction.

Uniswap widget button and loading states

Do you need any additional assets to make this happen?

@sirpy
Copy link
Contributor Author

sirpy commented Jul 15, 2024

i need a design. colors, where exactly the spinner is in our case and its size

@decentralauren
Copy link

See design in ticket #218

@decentralauren decentralauren assigned sirpy and L03TJ3 and unassigned decentralauren Sep 17, 2024
@L03TJ3
Copy link
Collaborator

L03TJ3 commented Sep 19, 2024

Closing this it will be part of designated buttons

@L03TJ3 L03TJ3 closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants