Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duration for streams is confusing/misleading #213

Closed
sirpy opened this issue Jul 9, 2024 · 7 comments
Closed

duration for streams is confusing/misleading #213

sirpy opened this issue Jul 9, 2024 · 7 comments
Assignees

Comments

@sirpy
Copy link
Contributor

sirpy commented Jul 9, 2024

The stream you create never ends, so if you have more G$s than the amount required for the "duration"
you will still keep on donating G$s.
Duration makes the user think that it is going to end at the end of the duration.

Better explanation or UI is required, also probably different for using G$ directly or using other currencies.

Maybe something like "donate for at least 12 months" and then tell user you dont have any G$s or you need to swap more tokens for the duration.
And a notice that you need to actively cancel the subscription after the duration.

Maybe using the word subscription makes more sense

@decentralauren
Copy link

@sirpy ok - we had designed with a set duration in mind - so you're saying we should just have people select "Monthly" and have it donate indefinitely (or until they connect their wallet and cancel the stream)?

@sirpy
Copy link
Contributor Author

sirpy commented Jul 14, 2024

That's how superfluid streams work. they are indefinite, until the user stops it or run out of funds

@decentralauren
Copy link

@sirpy we had originally set a duration because we needed to perform a swap for a certain amount of money - I believe that you had advised this as a solution. If streams are indefinite, how dow you suggest we handle the swaps?

@sirpy
Copy link
Contributor Author

sirpy commented Jul 16, 2024

I wrote my suggestion in the issue. I just suggest to change the texts/explanations.

@sirpy
Copy link
Contributor Author

sirpy commented Jul 22, 2024

@decentralauren

@decentralauren
Copy link

@decentralauren
Copy link

Being resolved through updates via this ticket, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants