Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: after stopping donation modal stays #215

Open
sirpy opened this issue Jul 10, 2024 · 7 comments
Open

Bug: after stopping donation modal stays #215

sirpy opened this issue Jul 10, 2024 · 7 comments

Comments

@sirpy
Copy link
Contributor

sirpy commented Jul 10, 2024

Problem:

  • When I confirm the TX to stop donation stream the modal stays
  • No confirmation of cancellation
  • After transaction user is redirected to their wallet

image.png

Update to:

  • After user confirms with their wallet, modal should switch to a spinner/loader until tx is confirmed.
  • Once confirmed, Modal should say "Your donation stream has been cancelled." with an "OK" button and X in the corner to dismiss.
  • User stays on page and state changes to showing "Donate" button as active again.
@decentralauren
Copy link

@sirpy yes I agree. Why is this assigned to me?

@sirpy
Copy link
Contributor Author

sirpy commented Jul 16, 2024

@decentralauren all issues I assign to you, require decision on UX (spinner? disappear?) + probably a design

@decentralauren
Copy link

@sirpy I understand, but your messages are unclear, and so I don't understand what you actually need me to do / whether it's a decision or action. For example, with this message, do you just need me to agree that yes the modal should disappear? Of course it should disappear.

@sirpy
Copy link
Contributor Author

sirpy commented Jul 16, 2024

I need you to analyze the case and decide on the UX you want and if it is something that requires displaying something new then also a design.
What I write in the issue are just suggestions from my point of view.

@sirpy
Copy link
Contributor Author

sirpy commented Jul 22, 2024

@decentralauren

@decentralauren decentralauren removed their assignment Aug 26, 2024
@decentralauren
Copy link

Updated the description with the appropriate solution.

@sirpy
Copy link
Contributor Author

sirpy commented Oct 1, 2024

Added a modal after TX sent, the modal will close once user closes it, or tx is completed.
image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants