Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GoodID] location certificate #523

Open
sirpy opened this issue Jan 25, 2024 · 8 comments
Open

[GoodID] location certificate #523

sirpy opened this issue Jan 25, 2024 · 8 comments
Assignees
Labels

Comments

@sirpy
Copy link
Contributor

sirpy commented Jan 25, 2024

Add an api endpoint to issue location certificate
inputs:

  • location data from browser
  • user ip
  • optional mobile number
    returns certificate

Create a method to issue location certificate

  • verify that location data from gps matches user ip geolocation
  • if mobile number is given, verify that user mobile was verified and matches our stored hash
  • if gps+ip resolves to same country or mobile is verified, then use the country from gps or mobile country code
  • issue certificate using veramo.io sdk
@johnsmith-gooddollar
Copy link
Collaborator

External services required

  • to get client IP + country data (we may use one to get ipv6 for captcha, need to check does it provides country info)
  • to get country from location coordinates (google reverse geo coding or find other one as google have strict limits for the free usage)
  • with mobile phones everything looks fine - just check country code from the number (we may have this list at the phone input)

@johnsmith-gooddollar
Copy link
Collaborator

  1. we're already using an external API to get country from IP address - won't change
  2. for reverse geo coding I suggest to use https://nominatim.openstreetmap.org/reverse?format=jsonv2&lat=-34.44076&lon=-58.70521 It's free and open, does not requires You to create any account

@patpedrosa
Copy link
Collaborator

@johnsmith-gooddollar In the case where gps+ip AND verified mobile differ, which one takes precedence?

@johnsmith-gooddollar
Copy link
Collaborator

johnsmith-gooddollar commented Feb 22, 2024

@johnsmith-gooddollar In the case where gps+ip AND verified mobile differ, which one takes precedence?

@patpedrosa data from the phone. actually if user have verified mobile, we don't even check gps and IP

@decentralauren
Copy link
Contributor

@L03TJ3 why is this on hold?

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Apr 2, 2024

@decentralauren That was requested by @vldkhh when we have items moving up from technical-review but are not really 'qa-able' yet

@vldkhh
Copy link

vldkhh commented Jun 25, 2024

verified on storybook

@vldkhh
Copy link

vldkhh commented Jul 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants