Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong code in getRequestUsingOffset method of AccountAPIProvider #31

Open
maxmmin opened this issue Jul 3, 2024 · 1 comment
Open

Wrong code in getRequestUsingOffset method of AccountAPIProvider #31

maxmmin opened this issue Jul 3, 2024 · 1 comment
Assignees
@GoodforGod
Labels
bug Something isn't working

Comments

@maxmmin
Copy link

maxmmin commented Jul 3, 2024

It has wrong logic. Etherscan allows fetching only 10k records. So paging with 10k-size page can't be implemented. And you didn't even make that method protected so i can't override it to use.
@maxmmin maxmmin added the bug Something isn't working label Jul 3, 2024
@maxmmin
Copy link
Author

maxmmin commented Jul 3, 2024

Haha, and BasicProvider is package-protected. I can't do nothing! Thank you so much!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GoodforGod GoodforGod

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GoodforGod @maxmmin