From 6aeec9086968591f5d28f75f0eb726a9ccfbabfd Mon Sep 17 00:00:00 2001 From: Jason Robbins Date: Thu, 19 Oct 2023 10:08:54 -0700 Subject: [PATCH] Remove unneeded install command. (#3427) * Remove unneeded install command. * Update playwright Dockerfile version. Make dependabot track Dockerfile updates (#3429) * Update playwright Dockerfile version Without this commit: `npm install` runs and installs the version in package.json which was 1.39 while the preinstalled browsers targeted playwright 1.37. Now that we are relying on the already installed libraries and browsers, we can get rid of the npm install in the Dockerfile too. TODO: Modify [dependabot](https://github.com/GoogleChrome/chromium-dashboard/blob/main/.github/dependabot.yml) to update the docker image. This should help prevent package.json playwright from outpacing the docker file image. * Update dependabot.yml to track Dockerfile updates * try * final --------- Co-authored-by: James C Scott III --- .github/dependabot.yml | 10 ++++++++++ packages/playwright/.dockerignore | 1 + packages/playwright/Dockerfile | 4 ++-- 3 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 packages/playwright/.dockerignore diff --git a/.github/dependabot.yml b/.github/dependabot.yml index bc52438e0ac4..15622365b35d 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -15,3 +15,13 @@ updates: reviewers: - "kyleju" - "jrobbins" + - package-ecosystem: "docker" + directory: "/" + schedule: + interval: "weekly" + commit-message: + # Prefix all commit messages with "docker" + prefix: "docker" + reviewers: + - "jrobbins" + - "jcscottiii" diff --git a/packages/playwright/.dockerignore b/packages/playwright/.dockerignore new file mode 100644 index 000000000000..3c3629e647f5 --- /dev/null +++ b/packages/playwright/.dockerignore @@ -0,0 +1 @@ +node_modules diff --git a/packages/playwright/Dockerfile b/packages/playwright/Dockerfile index 49fe0d22feb7..241ca68cdc92 100644 --- a/packages/playwright/Dockerfile +++ b/packages/playwright/Dockerfile @@ -1,4 +1,4 @@ -FROM mcr.microsoft.com/playwright:v1.37.1-jammy +FROM mcr.microsoft.com/playwright:v1.39.0-jammy ARG USERID ARG GROUPID @@ -18,6 +18,6 @@ USER pwuser WORKDIR /work # Cache the infrequent but time consuming changes early COPY --chown=pwuser:pwuser package.json /work/ -RUN npm install -D && npx playwright install +RUN npm install -D # Copy the rest COPY --chown=pwuser:pwuser . /work