Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annual shipping features nav links will break playwright tests twice a year #4490

Open
jrobbins opened this issue Oct 28, 2024 · 0 comments
Open
Assignees
Labels

Comments

@jrobbins
Copy link
Collaborator

We now have date-based logic that changes the navigation links in chromedash-drawer.ts twice a year. That will break our screenshot matching playwright tests twice a year. We could redact part of the image to exclude that part from image comparison, but that won't help with this change because it adds a row to the menu, thus affecting the layout of all the items lower in the menu.

@jrobbins jrobbins added the bug label Oct 28, 2024
@jrobbins jrobbins self-assigned this Oct 28, 2024
@jrobbins jrobbins changed the title annual shipping features nav links will break playwright tests twice a year Annual shipping features nav links will break playwright tests twice a year Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant