Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting for Python is broken #4559

Open
KyleJu opened this issue Nov 13, 2024 · 7 comments
Open

linting for Python is broken #4559

KyleJu opened this issue Nov 13, 2024 · 7 comments
Labels

Comments

@KyleJu
Copy link
Collaborator

KyleJu commented Nov 13, 2024

The linting for Python isn't working currently, as it is not analyzing any files:

Run npm run lint

> lint
> prettier client-src/js-src client-src/elements --check && eslint "client-src/js-src/**/*.{js,ts}" && tsc -p tsconfig.json && lit-analyzer "client-src/elements/chromedash-!(featurelist)*.js"

Checking formatting...
(node:2190) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
All matched files use Prettier code style!

  ✖ Couldn't find any files to analyze

  ✓ Found 0 problems in 0 files

e.g https://github.com/GoogleChrome/chromium-dashboard/actions/runs/11823294287/job/32942285509

@KyleJu KyleJu added the bug label Nov 13, 2024
@dv8081
Copy link

dv8081 commented Nov 14, 2024

@KyleJu can you please assign this to me.

@jrobbins
Copy link
Collaborator

jrobbins commented Nov 14, 2024

The lint target is actually looking at JS and TS code, not python.
I believe that the problem is the last part of the command:
lit-analyzer "client-src/elements/chromedash-!(featurelist)*.js"
We no longer have any *.js files in that directory because they were all converted to *.ts.

So, the fix is to change the command to also look at *.ts. However, we have some lit-analyzer errors that need to be addressed as part of that change.

@jrobbins
Copy link
Collaborator

In addition to the problem with npm run lint commented on above, there is also a problem with npm run pylint. We need to configure pylint to match our indentation conventions and then address a bunch of remaining lint items.

@r3yc0n1c
Copy link
Contributor

Hi, I’d like to work on this if it’s still available

@Varryme
Copy link

Varryme commented Dec 15, 2024

Please let me know if you need anything else you begin asap

@Varryme
Copy link

Varryme commented Dec 15, 2024

Can update me often

@r3yc0n1c
Copy link
Contributor

sure! WIP... will update you soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants