Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networkTimeoutSeconds #246

Closed
gauntface opened this issue Feb 28, 2017 · 2 comments · Fixed by #416
Closed

Add networkTimeoutSeconds #246

gauntface opened this issue Feb 28, 2017 · 2 comments · Fixed by #416
Assignees

Comments

@gauntface
Copy link

See: GoogleChromeLabs/sw-toolbox#221 for details

@jeffposnick jeffposnick self-assigned this Mar 10, 2017
@jeffposnick
Copy link
Contributor

This only makes sense when used with the NetworkFirst runtime handler, so I'll add it in there directly. (As opposed to adding in somewhere in the generic RequestWrapper interface.)

@gauntface
Copy link
Author

gauntface commented Mar 13, 2017

It would be good to capture Mat's comment in a test (i.e. if we set timeout of 1 second and request a test endpoint with a 4 second delay while we have a cached response, make sure we get the cached response within, say, 2 seconds and not some time after 4 seconds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants