Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't kill Firefox 57 #105

Open
robdodson opened this issue Nov 15, 2017 · 5 comments
Open

Can't kill Firefox 57 #105

robdodson opened this issue Nov 15, 2017 · 5 comments

Comments

@robdodson
Copy link
Contributor

It seems like the new FF doesn't get killed properly by seleniumAssistant.killWebDriver(driver);

@gauntface
Copy link

gauntface commented Jan 27, 2018

How did you get around this in your tests?

There is a very real chance that this was a discrepancy between selenium-webdriver and geckodriver :(

@robdodson
Copy link
Contributor Author

How did you get around this in your tests?

I didn't. When I run the tests locally, Firefox remains open but the tests themselves run to completion so everything passes.

@gauntface
Copy link

I just published 5.3.0 could you give that a shot, if it's failing, then I'll clone and try it out on your repo and get it fixed.

@robdodson
Copy link
Contributor Author

just tried with 5.3.0 but it remains open

@robdodson
Copy link
Contributor Author

github.com/wicg/focus-visible if you wanna give it a shot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants