From b11a375a803255be4fd848bc7062617bc48e6c84 Mon Sep 17 00:00:00 2001 From: Thorsten Kober Date: Mon, 24 Jun 2024 13:31:45 -0400 Subject: [PATCH 1/3] add missing options types --- src/types/type-declarations.ts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/types/type-declarations.ts b/src/types/type-declarations.ts index 435bb0c..be43f16 100644 --- a/src/types/type-declarations.ts +++ b/src/types/type-declarations.ts @@ -111,3 +111,21 @@ export interface GoogleTagManagerApi { dataLayer: Record[]; google_tag_manager: GoogleTagManager; } + +/* Google Maps Embed */ +export interface GoogleMapsEmbedOptions { + key: string; + mode: 'place' | 'view' | 'directions' | 'streetview' | 'search'; + q?: string; + center?: string; + zoom?: string; + maptype?: 'roadmap' | 'satellite'; + language?: string; + region?: string; +} + +/* Youtube Embed */ +export interface YoutubeEmbedOptions { + videoid: string; + playlabel?: string; +} From d2762d1ce853b619c904a8f5e7938930c228150c Mon Sep 17 00:00:00 2001 From: Thorsten Kober Date: Mon, 24 Jun 2024 14:23:13 -0400 Subject: [PATCH 2/3] Update src/types/type-declarations.ts Co-authored-by: Julien Huang --- src/types/type-declarations.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/types/type-declarations.ts b/src/types/type-declarations.ts index be43f16..17c5775 100644 --- a/src/types/type-declarations.ts +++ b/src/types/type-declarations.ts @@ -125,7 +125,7 @@ export interface GoogleMapsEmbedOptions { } /* Youtube Embed */ -export interface YoutubeEmbedOptions { +export interface YoutubeEmbedAttributes { videoid: string; playlabel?: string; } From e7a4ee3756b0324e2d4efcd2f6f93be06397c7c1 Mon Sep 17 00:00:00 2001 From: Thorsten Kober Date: Mon, 24 Jun 2024 14:53:39 -0400 Subject: [PATCH 3/3] rename types --- src/types/type-declarations.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/types/type-declarations.ts b/src/types/type-declarations.ts index 17c5775..2a940f3 100644 --- a/src/types/type-declarations.ts +++ b/src/types/type-declarations.ts @@ -60,7 +60,7 @@ export interface Output { } /* Google Analytics */ -export interface GoogleAnalyticsOptions { +export interface GoogleAnalyticsParams { id: string; } @@ -81,7 +81,7 @@ export interface GoogleAnalyticsApi { } /* Google Tag Manager */ -export interface GoogleTagManagerOptions { +export interface GoogleTagManagerParams { id: string; } @@ -113,7 +113,7 @@ export interface GoogleTagManagerApi { } /* Google Maps Embed */ -export interface GoogleMapsEmbedOptions { +export interface GoogleMapsEmbedParams { key: string; mode: 'place' | 'view' | 'directions' | 'streetview' | 'search'; q?: string;