From 6839bf858810991a9d876edf9a58451a19eac21c Mon Sep 17 00:00:00 2001 From: Julien Huang Date: Sat, 14 Sep 2024 15:06:51 +0200 Subject: [PATCH 1/2] chore: improve analytics types and optional params --- data/google-analytics.json | 3 +-- src/types/type-declarations.ts | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/data/google-analytics.json b/data/google-analytics.json index ed03bba..499badd 100644 --- a/data/google-analytics.json +++ b/data/google-analytics.json @@ -19,8 +19,7 @@ "params": ["id"], "optionalParams": { "l": "dataLayer", - "consentType": "default", - "consentValues": null + "consentType": "default" }, "strategy": "worker", "location": "head", diff --git a/src/types/type-declarations.ts b/src/types/type-declarations.ts index 3ba8994..bac74c0 100644 --- a/src/types/type-declarations.ts +++ b/src/types/type-declarations.ts @@ -74,7 +74,6 @@ export interface GoogleAnalyticsParams { consentType?: string; /** * Consent values for Google Analytics. - * @default {{"ad_user_data":"denied","ad_personalization":"denied","ad_storage":"denied","analytics_storage":"denied","wait_for_update":500}} */ consentValues?: { [key: string]: string }; } From 500f4769d64ff6bfa8365f8f162bc9504cedce4f Mon Sep 17 00:00:00 2001 From: Julien Huang Date: Sat, 14 Sep 2024 16:19:28 +0200 Subject: [PATCH 2/2] fix: add back null value --- data/google-analytics.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data/google-analytics.json b/data/google-analytics.json index 499badd..ed03bba 100644 --- a/data/google-analytics.json +++ b/data/google-analytics.json @@ -19,7 +19,8 @@ "params": ["id"], "optionalParams": { "l": "dataLayer", - "consentType": "default" + "consentType": "default", + "consentValues": null }, "strategy": "worker", "location": "head",