-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concerns with assumptions and limitations of UnixBench #125
Comments
These are great points! It looks like we should adjust the benchmark to better fit how the tool is actually used to measure systems (including more CPUs). This change however would effect the default behavior of UnixBench and would require the community to agree to make it the default. Any chance you can prototype this change in a separate branch and then share the comparison data on this issue thread? We can then include the proposed CL in the next community meeting on 3/18. If everyone agrees we take the change and are done. If we need to escalate Christos from Stanford and Daniel from MIT decide. Ivan make also speak at the community meeting with a proposal on how to take changes that is a bit more codified. |
TL;DR - I think you're right and we should do this. Let's test the workflow on how to change stuff. I will likely create another issue to track this, but here is what I was thinking:
What do you think? |
Sounds reasonable. I'll work on a CL in a separate branch. IMHO, the changes to make UnixBench run on more than 16 CPUs doesn't really change UnixBench's behavior, anywhere were you had < 16 CPUs will continue to run the same way and I wouldn't expect any changes on the results. The other suggested change of using pre-compiled binaries for each of the UnixBench benchmarks listed here, will definitely be considered as a "breaking" change. |
I am happy with the flag solution as it is simpler and let us postpone On Mon, Feb 23, 2015 at 3:41 PM, Carlos Torres [email protected]
|
Carlos - Thanks for fixing part 1 with #135 What do you suggest for the other two? |
@voellm For the other two, I opened an issue in the UnixBench repo for my proposal to address these, kdlucas/byte-unixbench#23 |
I have several concerns with the current usage of UnixBench. I know that most people seems to run UnixBench 'as is' with whatever defaults are set, but I believe this will not show a proper comparison between systems (i.e. OS versions, Compiler versions, libC versions, etc).
Here's why:
What is your take on these issues?
The text was updated successfully, but these errors were encountered: