From f743e2515c58db7ab9fa41624bd70b23b92e1568 Mon Sep 17 00:00:00 2001 From: Anna Pendleton Date: Wed, 4 Sep 2024 12:11:39 -0700 Subject: [PATCH] update lpg to deploy latest build on new build (#797) * wait to finish latest build before deploying manifests, update sample to ensure build happens first try * fix sample.tfvars * terraform fmt --- benchmarks/benchmark/tools/profile-generator/main.tf | 5 +++-- benchmarks/benchmark/tools/profile-generator/sample.tfvars | 5 ++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/benchmarks/benchmark/tools/profile-generator/main.tf b/benchmarks/benchmark/tools/profile-generator/main.tf index 292b6122e..0fb5c3b2b 100644 --- a/benchmarks/benchmark/tools/profile-generator/main.tf +++ b/benchmarks/benchmark/tools/profile-generator/main.tf @@ -51,8 +51,9 @@ resource "google_project_service" "cloudbuild" { # ----- Manual Benchmarking ----- module "latency-profile" { - count = var.targets.manual != null ? 1 : 0 - source = "./modules/latency-profile" + depends_on = [resource.null_resource.build_and_push_image] + count = var.targets.manual != null ? 1 : 0 + source = "./modules/latency-profile" credentials_config = var.credentials_config namespace = var.namespace diff --git a/benchmarks/benchmark/tools/profile-generator/sample.tfvars b/benchmarks/benchmark/tools/profile-generator/sample.tfvars index de2be79ec..b2e888ff6 100644 --- a/benchmarks/benchmark/tools/profile-generator/sample.tfvars +++ b/benchmarks/benchmark/tools/profile-generator/sample.tfvars @@ -22,8 +22,11 @@ credentials_config = { project_id = "your_project_id" +namespace = "benchmark" + # Latency profile generator service configuration -build_latency_profile_generator_image = false +# set build_latency_profile_generator_image to false to save 20 min build if no rebuild needed, eg. +# build_latency_profile_generator_image = false latency_profile_kubernetes_service_account = "prom-frontend-sa" output_bucket = "your_project_id-benchmark-output-bucket" k8s_hf_secret = "hf-token"