Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the README to reflect the correct sample dataset & surface this info earlier in the README #438

Open
kumar-dhanagopal opened this issue Mar 25, 2024 · 2 comments
Open

Update the README to reflect the correct sample dataset & surface this info earlier in the README #438

kumar-dhanagopal opened this issue Mar 25, 2024 · 2 comments

Comments

@kumar-dhanagopal
Copy link
Member

  1. Currently, https://github.com/GoogleCloudPlatform/ai-on-gke/blob/main/applications/rag/README.md mentions that the example uses https://www.kaggle.com/datasets/denizbilginn/google-maps-restaurant-reviews as the input dataset. However, per Switch to Netflix data set #385, the example uses a "Netflix shows" dataset.

  2. To help users quickly understand what the sample application does, consider mentioning the example dataset upfront in the introductory section of the README. Currently, the dataset info is buried rather deep in the README.
@andrewsykim
Copy link
Collaborator

andrewsykim commented Mar 26, 2024 •
edited
Loading

Adding to this, the value of TABLE_NAME is still googlemaps_reviews_db, should be netflix_reviews_db or something similar

@andrewsykim
Copy link
Collaborator

I believe @imreddy13 is working on this already #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewsykim @kumar-dhanagopal