From 870f754014c2a9e2ead39c1276f93e4c18815065 Mon Sep 17 00:00:00 2001 From: "Mengye (Max) Gong" <8364575+gongmax@users.noreply.github.com> Date: Fri, 6 Sep 2024 09:37:44 -0700 Subject: [PATCH 1/2] Update contributing.md to include description of how to find build logs --- contributing.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/contributing.md b/contributing.md index e635be7ae..0e52692ae 100644 --- a/contributing.md +++ b/contributing.md @@ -30,3 +30,13 @@ Guidelines](https://opensource.google/conduct/). All submissions, including submissions by project members, require review. We use [GitHub pull requests](https://docs.github.com/articles/about-pull-requests) for this purpose. + +After creating a PR, a contributor needs to add `/gcbrun` to the comment to trigger CI +for the PR, which includes the CloudBuild triggered e2e test `pr-review-trigger` +and `pr-review-trigger-ap-clusters` as shown below. +![image](https://github.com/user-attachments/assets/6a759456-e1dd-4a3b-95da-84c9f2b8b053) + +If any of the build fails, you can find the link to the build log for these triggers at +the bottom of the details page by clicking `Details` link. + + From bf7a9fcee96ab171380d924b204b7b6828436a9c Mon Sep 17 00:00:00 2001 From: "Mengye (Max) Gong" <8364575+gongmax@users.noreply.github.com> Date: Fri, 6 Sep 2024 09:55:18 -0700 Subject: [PATCH 2/2] Update contributing.md --- contributing.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contributing.md b/contributing.md index 0e52692ae..fd5eda68d 100644 --- a/contributing.md +++ b/contributing.md @@ -31,12 +31,12 @@ All submissions, including submissions by project members, require review. We use [GitHub pull requests](https://docs.github.com/articles/about-pull-requests) for this purpose. -After creating a PR, a contributor needs to add `/gcbrun` to the comment to trigger CI -for the PR, which includes the CloudBuild triggered e2e test `pr-review-trigger` -and `pr-review-trigger-ap-clusters` as shown below. +After creating a pull request, a collaborator needs to add `/gcbrun` as a comment +to trigger CI for the PR, which includes the CloudBuild triggered e2e test +`pr-review-trigger` and `pr-review-trigger-ap-clusters` as shown below. ![image](https://github.com/user-attachments/assets/6a759456-e1dd-4a3b-95da-84c9f2b8b053) -If any of the build fails, you can find the link to the build log for these triggers at +If any of the builds fail, you can find the link to the build log for these triggers at the bottom of the details page by clicking `Details` link.