Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Spring Data R2DBC Transaction Manager #314

Open
dzou opened this issue Mar 1, 2021 · 0 comments
Open

Upgrade Spring Data R2DBC Transaction Manager #314

dzou opened this issue Mar 1, 2021 · 0 comments
Assignees
@elefeint
Labels
enhancement New feature or request P2
Milestone
h2-2022-candidates

Comments

@dzou
Copy link
Contributor

dzou commented Mar 1, 2021

Looks like Spring Data R2DBC has had several new version released; we should get us up to date on the latest there.

In particular, it looks like we need to extend a custom R2dbcTransactionManager to support several Spanner operations like creating custom transaction types; potentially other clever things we can do in there.

I've posted a question here asking how to do best do this: spring-projects/spring-data-r2dbc#547
@dzou dzou added the enhancement New feature or request label Mar 1, 2021
@elefeint elefeint mentioned this issue Mar 16, 2021
Closed
@elefeint elefeint self-assigned this Mar 22, 2021
@elefeint elefeint mentioned this issue Mar 29, 2021
Merged
elefeint added a commit that referenced this issue Mar 29, 2021
@elefeint
Upgrade to modern Spring Data R2DBC (#347)
6efbf51 
Spring Data dialect updates:
* Many supporting classes moved from Spring Data into Spring Framework.
* Spring Boot integration is no longer in experimental; it's part of mainstream Boot autoconfiguration.
* The need for `SpannerBindMarkerFactoryProvider` is a bit redundant since the same information can be derived from dialect, which is already getting autodiscovered. But it's documented [here](https://docs.spring.io/spring-framework/docs/current/reference/html/data-access.html#r2dbc-DatabaseClient).

Updated sample:
* Explicitly specifying `@Column` is needed because v1 is case-sensitive. We have fixed it to comply with case-insensitive spec for v2 in #271 , so this should become unnecessary when we migrate to v2.

Necessary but not sufficient step towards #314.
@elefeint elefeint changed the title Spring Data R2DBC Updates Upgrade Spring Data R2DBC Transaction Manager May 12, 2022
@elefeint elefeint added this to the h2-2022-candidates milestone May 12, 2022
@elefeint elefeint added the P2 label Aug 12, 2022
@meltsufin meltsufin mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elefeint elefeint

Labels
enhancement New feature or request P2
Projects
None yet
Milestone
h2-2022-candidates
Development

No branches or pull requests
2 participants
@dzou @elefeint