You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but I'm not sure I'd roll my own retry loops there's plenty of golang libraries for this.
Make the retry logic not fail after 3 times. Make it time bound like say if I keep getting failures for 5 minutes then give up.
Permanent Fix:
Read from Stackdriver logs as the primary source. If there's no access fallback to GetSerialPortOutput with a less aggressive polling internal. Once per minute instead of once every 10 seconds.
These all sound like reasonable approaches. If you're interested in writing a PR, we could chat about specifics, and I think @adjackura would have some thoughts too.
Before that, I'm curious: How often do your builds fail due to this?
It looks like if there's multiple GetSerialPortOutput failures, Daisy will halt the process.
compute-image-tools/daisy/step_wait_for_instances_signal.go
Line 144 in dc64ab8
The text was updated successfully, but these errors were encountered: