Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save button not always enabling when policy selection changed #420

Merged
merged 5 commits into from
Jan 9, 2021
Merged

Save button not always enabling when policy selection changed #420

merged 5 commits into from
Jan 9, 2021

Conversation

mservidio
Copy link
Contributor

@mservidio mservidio commented Jan 8, 2021 •
edited
Loading

Fixes: #398
Not sure if this is caused by observable data potentially. Converting them to arrays to further understand, also may be a potential fix?

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

@mservidio mservidio added the bug Something isn't working label Jan 8, 2021
@mservidio mservidio self-assigned this Jan 8, 2021
@mservidio mservidio requested a review from a team as a code owner January 8, 2021 17:58
phriscage
phriscage approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@phriscage phriscage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mservidio mservidio merged commit b5d59c2 into master Jan 9, 2021
@mservidio mservidio deleted the 398---account-save-button-doesn't-always-enable branch January 9, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phriscage phriscage phriscage approved these changes

Assignees

@mservidio mservidio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@mservidio @phriscage