New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Add Data Format type to Export Agent method #126

Open

kmaphoenix opened this issue May 11, 2023 · 1 comment

Member

kmaphoenix commented May 11, 2023

The export_agent method is missing the data_format parameter which can be supplied by users to determine the output data format type.

Refs for data_format here:
https://github.com/googleapis/python-dialogflow-cx/blob/main/google/cloud/dialogflowcx_v3beta1/types/agent.py#L355

The text was updated successfully, but these errors were encountered:

Member Author

kmaphoenix commented May 11, 2023

Note that the data_format is provided as a proto Enum:
https://github.com/googleapis/python-dialogflow-cx/blob/main/google/cloud/dialogflowcx_v3beta1/types/agent.py#L384

We should simplify this and allow the user to provide str inputs like blob, json and then map them to the enum value as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment