Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug With vsphere_network #71

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Bug With vsphere_network #71

merged 2 commits into from
Feb 14, 2024

Conversation

umeshkumhar
Copy link
Collaborator

@umeshkumhar umeshkumhar commented Feb 12, 2024 •
edited
Loading

Bug Fix

  • Removed data block for private_cloud, as not necessary network will always exists.. plan fails if both are created in single go.
  • Added new parameter to support vmware network location. as it can have global as value.
  • gcve_region, is not supported actually, gcve private cloud cluster can be zonal only.

@umeshkumhar umeshkumhar requested a review from a team as a code owner February 12, 2024 11:04
@umeshkumhar umeshkumhar changed the title Update main.tf Bug With vsphere_network Feb 12, 2024
KonradSchieban
KonradSchieban approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@KonradSchieban KonradSchieban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KonradSchieban KonradSchieban merged commit 6b09067 into main Feb 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradSchieban KonradSchieban KonradSchieban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umeshkumhar @KonradSchieban