Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hpa-example from sample manifests #557

Open
shannonxtreme opened this issue Apr 12, 2023 · 3 comments
Open

Remove hpa-example from sample manifests #557

shannonxtreme opened this issue Apr 12, 2023 · 3 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@shannonxtreme
Copy link
Contributor

shannonxtreme commented Apr 12, 2023

gke-scheduled-autoscaler/k8s/deployment-example.yaml uses k8s.gcr.io/hpa-example as the image. It's not used in any of our docs, so I think this should be ok to change.

In kubernetes/release#2924 (comment), it's suggested that hpa-example is going to be removed in the near future. We should replace the image in this repo with either a forked version or a different image.

cc @bourgeoisor

@bourgeoisor
Copy link
Member

@rbarberop FYI
In https://cloud.google.com/kubernetes-engine/docs/how-to/multidimensional-pod-autoscaling#creating_a_deployment, hpa-example was changed for hello-app.

@bourgeoisor bourgeoisor added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Apr 12, 2023
@bourgeoisor
Copy link
Member

@rbarberop I was looking into usage of that file (https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/blob/main/gke-scheduled-autoscaler/k8s/deployment-example.yaml) and don't see it being used in the associated tutorial (https://cloud.google.com/kubernetes-engine/docs/tutorials/reducing-costs-by-scaling-down-gke-off-hours). Is it okay to remove deployment-example.yaml from the repo (see reasoning above)? Or is it used elsewhere?

@rbarberop
Copy link
Collaborator

LGTM @bourgeoisor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants