Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Terraform duplication in streaming/ #861

Open
3 tasks
NimJay opened this issue Sep 6, 2023 · 1 comment
Open
3 tasks

Remove Terraform duplication in streaming/ #861

NimJay opened this issue Sep 6, 2023 · 1 comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@NimJay
Copy link
Collaborator

NimJay commented Sep 6, 2023

  • See this comment.
  • The Terraform inside /streaming/kafka-strimzi/terraform is mostly identical to the Terraform added by feat: samples for Confluent operator tutorial #725.
  • We should minimize this duplication.
  • This would involve:
    • creating more generic (re-usable) Terraform (e.g., inside /streaming/kafka/terraform)
    • updating the two tutorials (Strimzi and Confluent) to use the new generic Terraform (/streaming/kafka/terraform)
    • removing unused Strimzi-specific and Confluent-sepecific Terraform from this repo
@NimJay NimJay added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 6, 2023
@NimJay
Copy link
Collaborator Author

NimJay commented Nov 20, 2024

We should consider creating a Terraform module (or modules) shared repo-wide.
More Terraform (similar to existing Terraform) was introduced via https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/1487/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant