From 2f6ab4a1c2b54069a83cebe109819630e68e9f46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20J=C4=99draszewski?= Date: Tue, 28 Jan 2025 11:36:15 +0000 Subject: [PATCH] Remove unsupported properties + fix formatting --- .../NetworkFirewallPolicyPacketMirroringRule.yaml | 9 +-------- ...network_firewall_policy_packet_mirroring_rule.tf.tmpl | 4 ++-- ...rk_firewall_policy_packet_mirroring_rule_test.go.tmpl | 5 +---- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/mmv1/products/compute/NetworkFirewallPolicyPacketMirroringRule.yaml b/mmv1/products/compute/NetworkFirewallPolicyPacketMirroringRule.yaml index 9a5aed6ccbfb..5631a6c00439 100644 --- a/mmv1/products/compute/NetworkFirewallPolicyPacketMirroringRule.yaml +++ b/mmv1/products/compute/NetworkFirewallPolicyPacketMirroringRule.yaml @@ -42,21 +42,14 @@ async: type: 'OpAsync' operation: base_url: '{{op_id}}' - kind: 'compute#operation' - path: 'name' - wait_ms: 1000 result: - path: 'targetLink' resource_inside_response: false - error: - path: 'error/errors' - message: 'message' examples: - name: 'compute_network_firewall_policy_packet_mirroring_rule' primary_resource_id: 'primary' vars: fw_policy: 'fw-policy' - network_name: 'network' + network_name: 'fw-network' tag_key: 'tag-key' tag_value: 'tag-value' deployment_group_id: 'deployment-group' diff --git a/mmv1/templates/terraform/examples/compute_network_firewall_policy_packet_mirroring_rule.tf.tmpl b/mmv1/templates/terraform/examples/compute_network_firewall_policy_packet_mirroring_rule.tf.tmpl index 2ed4e41167ea..4cd3879e841f 100644 --- a/mmv1/templates/terraform/examples/compute_network_firewall_policy_packet_mirroring_rule.tf.tmpl +++ b/mmv1/templates/terraform/examples/compute_network_firewall_policy_packet_mirroring_rule.tf.tmpl @@ -34,8 +34,8 @@ resource "google_compute_network_firewall_policy_packet_mirroring_rule" "{{$.Pri security_profile_group = "//networksecurity.googleapis.com/${google_network_security_security_profile_group.security_profile_group_1.id}" target_secure_tags { - name = "tagValues/${google_tags_tag_value.secure_tag_value_1.name}" - } + name = "tagValues/${google_tags_tag_value.secure_tag_value_1.name}" + } } resource "google_network_security_mirroring_deployment_group" "default" { diff --git a/mmv1/third_party/terraform/services/compute/resource_compute_network_firewall_policy_packet_mirroring_rule_test.go.tmpl b/mmv1/third_party/terraform/services/compute/resource_compute_network_firewall_policy_packet_mirroring_rule_test.go.tmpl index b124bc8acc44..6dcb837d7e29 100644 --- a/mmv1/third_party/terraform/services/compute/resource_compute_network_firewall_policy_packet_mirroring_rule_test.go.tmpl +++ b/mmv1/third_party/terraform/services/compute/resource_compute_network_firewall_policy_packet_mirroring_rule_test.go.tmpl @@ -73,12 +73,9 @@ resource "google_compute_network_firewall_policy" "basic_network_firewall_policy resource "google_compute_network_firewall_policy_packet_mirroring_rule" "primary" { provider = google-beta action = "do_not_mirror" - description = "This is a simple packet mirroring rule description" direction = "INGRESS" - disabled = false firewall_policy = google_compute_network_firewall_policy.basic_network_firewall_policy.name priority = 1000 - rule_name = "test-rule" match { src_ip_ranges = ["10.100.0.1/32"] @@ -130,7 +127,7 @@ resource "google_compute_network_firewall_policy_packet_mirroring_rule" "primary security_profile_group = "//networksecurity.googleapis.com/${google_network_security_security_profile_group.security_profile_group_1.id}" target_secure_tags { - name = "tagValues/${google_tags_tag_value.secure_tag_value_1.name}" + name = "tagValues/${google_tags_tag_value.secure_tag_value_1.name}" } }