Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk related fields to google_compute_instance #13193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

karolgorc
Copy link
Contributor

@roaks3
related to #13147

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `architecture` and `guest_os_features` to `google_compute_instance`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from slevenick February 26, 2025 13:01
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 26, 2025
@github-actions github-actions bot requested a review from slevenick February 27, 2025 07:05
@modular-magician modular-magician added service/compute-instances and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 27, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 128 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 128 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 56 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_instance (348 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  boot_disk {
    device_name = # value needed
    initialize_params {
      enable_confidential_compute = # value needed
    }
  }
}

Resource: google_compute_instance_from_machine_image (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  boot_disk {
    guest_os_features = # value needed
    initialize_params {
      architecture = # value needed
    }
  }
}

Resource: google_compute_instance_from_template (20 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  boot_disk {
    auto_delete             = # value needed
    device_name             = # value needed
    disk_encryption_key_raw = # value needed
    guest_os_features       = # value needed
    initialize_params {
      architecture                = # value needed
      enable_confidential_compute = # value needed
      image                       = # value needed
      labels                      = # value needed
      provisioned_iops            = # value needed
      provisioned_throughput      = # value needed
      resource_manager_tags       = # value needed
      resource_policies           = # value needed
      size                        = # value needed
      storage_pool                = # value needed
      type                        = # value needed
    }
    kms_key_self_link = # value needed
    mode              = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1125
Passed tests: 1045
Skipped tests: 79
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstance_guestOsFeatures

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeInstance_guestOsFeatures [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants