-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disk related fields to google_compute_instance #13193
base: main
Are you sure you want to change the base?
Add disk related fields to google_compute_instance #13193
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
mmv1/third_party/terraform/website/docs/r/compute_instance.html.markdown
Outdated
Show resolved
Hide resolved
…l.markdown Co-authored-by: Sam Levenick <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance" "primary" {
boot_disk {
device_name = # value needed
initialize_params {
enable_confidential_compute = # value needed
}
}
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
boot_disk {
guest_os_features = # value needed
initialize_params {
architecture = # value needed
}
}
}
Resource: resource "google_compute_instance_from_template" "primary" {
boot_disk {
auto_delete = # value needed
device_name = # value needed
disk_encryption_key_raw = # value needed
guest_os_features = # value needed
initialize_params {
architecture = # value needed
enable_confidential_compute = # value needed
image = # value needed
labels = # value needed
provisioned_iops = # value needed
provisioned_throughput = # value needed
resource_manager_tags = # value needed
resource_policies = # value needed
size = # value needed
storage_pool = # value needed
type = # value needed
}
kms_key_self_link = # value needed
mode = # value needed
}
}
|
Tests analyticsTotal tests: 1125 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
@roaks3
related to #13147
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.