Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to user-managed firewall rules for GKE Load Balancer Services #13118

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Add support to user-managed firewall rules for GKE Load Balancer Services #13118

wants to merge 41 commits into from
+191 −42

Conversation

maxi-cit
Copy link
Contributor

@maxi-cit maxi-cit commented Feb 19, 2025 •
edited
Loading

GKE automatically creates legacy VPC firewall rules for load balancers. Customers want to disable the automated flags in certain cases.

Release Note Template for Downstream PRs (will be copied)

container: added `disable_l4_lb_firewall_reconciliation` field to `google_container_cluster` resource

Upgrade dependency google.golang.org/api to v0.221.0

@github-actions github-actions bot requested a review from SirGitsalot February 19, 2025 09:15
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 19, 2025
@maxi-cit
Copy link
Contributor Author

Hello @SirGitsalot could you run tests please? I d like to kno if GA is working fine, thanks!

@github-actions GitHub Actions
Copy link

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

SirGitsalot
SirGitsalot reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I fixed the merge conflict, kicked off the tests on the CI system, and will approve once they complete successfully. Thanks!

PerlMonker303 and others added 19 commits February 27, 2025 12:27
@PerlMonker303 @maxi-cit
Promote Gemini Gcp Enablement Setting Binding from google-beta to goo…
a507d02 
…gle (GoogleCloudPlatform#13168)
@zli82016 @maxi-cit
Update tgc revival import references (GoogleCloudPlatform#13173)
cc9b18c
@JaylonmcShan03 @maxi-cit
Add policyMode field (GoogleCloudPlatform#13013)
b387fb4
@gurusai-voleti @maxi-cit
fix: (storage) fix multi location rpo test case (GoogleCloudPlatform#…
96afc53 
…13119)
@wj-chen @maxi-cit
Update max_staleness in google_bigquery_table to be a computed field (G…
5235f40 
…oogleCloudPlatform#13167)
@karolgorc @maxi-cit
Add missing field to disks and support InstantSnapshot (GoogleCloudPl…
7148f83 
…atform#12946)
@JaylonmcShan03 @maxi-cit
Fix AlloyDB availabilityType documentation (GoogleCloudPlatform#13025)
0a203c9
@roaks3 @maxi-cit
Fix resource type used for IAM service account key (GoogleCloudPlatfo…
65747fe 
…rm#13180)
@trodge @maxi-cit
Change Sprintf to Sprint (GoogleCloudPlatform#13077)
afb90e7
@cerberus97 @maxi-cit
Deprecate google_data_catalog_tag (GoogleCloudPlatform#13098)
418af4d 
Co-authored-by: Hanit Banga <[email protected]>
@melinath @maxi-cit
Added missing service label handling to generate_comment (GoogleCloud…
ea34b8b 
…Platform#13143)
@matheusaleixo-cit @maxi-cit
Promoted Instance NetworkAttachment field to V1; (GoogleCloudPlatform…
f78fbc3 
…#13067)
@edwinfranciss @maxi-cit
Add HostProjectRegistration resource in API hub (GoogleCloudPlatform#…
288ac95 
…13092)
@shuyama1 @maxi-cit
update google_folder doc to include deletion_protection (GoogleCloudP…
d2be1b5 
…latform#13153)
@yliaog @maxi-cit
added enum UPGRADE_INFO_EVENT for notification filter (GoogleCloudPla…
741989c 
…tform#13174)
@ankitgoyal0301 @maxi-cit
Fixes issue #21347 related to google_chronicle_rule_deployment resour…
d391866 
…ce (GoogleCloudPlatform#13130)
@tommyreddad @maxi-cit
Add google_eventarc_message_bus resource (GoogleCloudPlatform#13042)
f56c160
@makotonakai @maxi-cit
Encode b64_mac_key in base64url, not in base64 (GoogleCloudPlatform#1…
6809a7f 
…3033)
@BBBmau @zli82016
@rileykarson @maxi-cit
feature: ephemeral write-only support (GoogleCloudPlatform#13135)
822227e 
Co-authored-by: Zhenhua Li <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
roaks3 and others added 15 commits February 27, 2025 12:29
@roaks3 @maxi-cit
Fix some remaining incorrect metadata 20250224 (GoogleCloudPlatform#1…
62a36d1 
…3170)
@GauravJain21 @zli82016 @maxi-cit
Add examples for AlloyDB Major Version Upgrade (GoogleCloudPlatform#1…
c08148e 
…3177)

Co-authored-by: Zhenhua Li <[email protected]>
@BBBmau @maxi-cit
fix type check panic on GetRawConfigAt (GoogleCloudPlatform#13204)
19dd9db
@AshZhang @maxi-cit
Add location field to google_network_services_grpc_route (GoogleCloud…
ed81fd0 
…Platform#13044)
@harrisonlimh @maxi-cit
Update to use a regional template bucket (GoogleCloudPlatform#13187)
1559e41
@roaks3 @maxi-cit
Add back agentPools a resource type kind (GoogleCloudPlatform#13198)
f8495dc
@omkark-google @maxi-cit
Extra attributes saml support (GoogleCloudPlatform#13183)
354e20b
@gurusai-voleti @maxi-cit
fix: (storage) bucket policy delete 412 error (GoogleCloudPlatform#12944
58aa567 
)
@xujiongda @maxi-cit
Update document for Dataproc cluster ProvisioningModelMix field (Goog…
cdfd064 
…leCloudPlatform#13191)
@stefan-malin-db @stefan-malin-ing
@melinath @maxi-cit
Fix: Address issue hashicorp#19621 in discoveryengine module (GoogleC…
d195d15 
…loudPlatform#13021)

Co-authored-by: stefan.malin <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
@PerlMonker303 @maxi-cit
Promote Gemini Data Sharing With Google Setting Binding from google-b…
fee037a 
…eta to google (GoogleCloudPlatform#13121)
@PerlMonker303 @maxi-cit
Update Gemini Logging Setting Binding Resource - Change product possi…
21701d6 
…ble values (GoogleCloudPlatform#13169)
@Dawid212 @maxi-cit
add region_ssl_policy data source (GoogleCloudPlatform#13122)
c29184b
@swamitagupta @maxi-cit
Update PrivateCloud documentation to include the expected stretch clu…
b18f664 
…ster location format (GoogleCloudPlatform#13208)
@maxi-cit
fixed conflicts
a7b7917
@github-actions github-actions bot requested a review from SirGitsalot February 27, 2025 17:32
@maxi-cit
Copy link
Contributor Author

Hello @SirGitsalot I rebased my branch to match your changes and fix some conflicts with main. Now it should be merge-able

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirGitsalot SirGitsalot Awaiting requested review from SirGitsalot

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.