Stop setting the description field of google_gke_hub_membership #13185
+0
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan to update the gkehub beta api endpoint from v1beta1 to v1beta. Unfortunately, the description field is output-only in v1beta and cannot be set by users.
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 11 Click here to see the affected service packages
🟢 All tests passed! View the build log |
c2thorn
approved these changes
Feb 27, 2025
Merged
via the queue into
GoogleCloudPlatform:main
with commit Feb 27, 2025
1eb111a
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to update the gkehub beta api endpoint from v1beta1 to v1beta. Unfortunately, the description field is output-only in v1beta and cannot be set by users.
part of hashicorp/terraform-provider-google#21641
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.