-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline MLPerf Benchmarking #483
Open
patemotter
wants to merge
1
commit into
master
Choose a base branch
from
patemotter_maxtext_offline
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+299
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patemotter
requested review from
yeandy,
vipannalla,
morgandu,
mailvijayasingh,
sixiang-google,
JoeZijunZhou,
singh-mitali,
mbzomowski,
RissyRan and
allenwang28
as code owners
November 21, 2024 21:59
patemotter
force-pushed
the
patemotter_maxtext_offline
branch
from
November 21, 2024 22:02
057879c
to
dc9ace7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - looks great. Left some comments.
patemotter
force-pushed
the
patemotter_maxtext_offline
branch
5 times, most recently
from
December 6, 2024 20:47
911a1c3
to
26dd0e8
Compare
patemotter
force-pushed
the
patemotter_maxtext_offline
branch
2 times, most recently
from
December 9, 2024 20:14
8e9ba08
to
4ac5cea
Compare
vipannalla
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
patemotter
force-pushed
the
patemotter_maxtext_offline
branch
from
December 12, 2024 23:28
4ac5cea
to
9372795
Compare
patemotter
force-pushed
the
patemotter_maxtext_offline
branch
from
December 13, 2024 00:09
9372795
to
f1ef42c
Compare
Fix. . . . Working except for metrics upload. Working Formatting fixes. Better handling of package and git info. Combines the results Fixes copy issue with retries Working e2e version. Formatting Adds schedule Removes test flag Uses mainline maxtext
patemotter
force-pushed
the
patemotter_maxtext_offline
branch
from
December 13, 2024 00:09
f1ef42c
to
dc2e188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds offline MLPerf benchmarking to run Llama2-70B v6e-8. Requires the changes in related MaxText PR to be merged in order to work correctly.
Tests
Ran e2e using the dev environment. Confirmed completion and correct uploading of metrics after the run.
Instruction and/or command lines to reproduce your tests:
Running the
maxtext_inference_offline_benchmark
DAG in the dev environment.List links for your tests (use go/shortn-gen for any internal link):
Test history in dev environment: http://shortn/_QYByqVphuT
Checklist
Before submitting this PR, please make sure (put X in square brackets):