Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline MLPerf Benchmarking #483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patemotter
Copy link
Collaborator

@patemotter patemotter commented Nov 21, 2024

Description

Adds offline MLPerf benchmarking to run Llama2-70B v6e-8. Requires the changes in related MaxText PR to be merged in order to work correctly.

Tests

Ran e2e using the dev environment. Confirmed completion and correct uploading of metrics after the run.

Instruction and/or command lines to reproduce your tests:

Running the maxtext_inference_offline_benchmark DAG in the dev environment.

List links for your tests (use go/shortn-gen for any internal link):

Test history in dev environment: http://shortn/_QYByqVphuT

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run one-shot tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@singh-mitali singh-mitali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks great. Left some comments.

dags/inference/maxtext_inference_offline_benchmark.py Outdated Show resolved Hide resolved
dags/inference/maxtext_inference_offline_benchmark.py Outdated Show resolved Hide resolved
dags/inference/maxtext_inference_offline_benchmark.py Outdated Show resolved Hide resolved
dags/inference/maxtext_inference_offline_benchmark.py Outdated Show resolved Hide resolved
dags/inference/maxtext_inference_offline_benchmark.py Outdated Show resolved Hide resolved
@patemotter patemotter force-pushed the patemotter_maxtext_offline branch 5 times, most recently from 911a1c3 to 26dd0e8 Compare December 6, 2024 20:47
@patemotter patemotter force-pushed the patemotter_maxtext_offline branch 2 times, most recently from 8e9ba08 to 4ac5cea Compare December 9, 2024 20:14
Copy link
Collaborator

@vipannalla vipannalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fix.

.

.

.

Working except for metrics upload.

Working

Formatting fixes.

Better handling of package and git info.

Combines the results

Fixes copy issue with retries

Working e2e version.

Formatting

Adds schedule

Removes test flag

Uses mainline maxtext
@patemotter patemotter force-pushed the patemotter_maxtext_offline branch from f1ef42c to dc2e188 Compare December 13, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants