Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GCM Mock API in favor of integration tests #84

Open
aabmass opened this issue Oct 23, 2020 · 3 comments
Open

remove GCM Mock API in favor of integration tests #84

aabmass opened this issue Oct 23, 2020 · 3 comments

Comments

@aabmass
Copy link
Collaborator

aabmass commented Oct 23, 2020

Need to update code introduced in #83 when these issues are closed:
googleinterns/cloud-operations-api-mock#58
googleinterns/cloud-operations-api-mock#56

@aabmass
Copy link
Collaborator Author

aabmass commented Sep 27, 2022

The cloud mock project has been archived and we will be using integration tests against real gcm in place of this. I think the fix here is to migrate to integration tests and remove the cloud mock dep altogether.

@aabmass aabmass changed the title remove hacks for GCM Mock API remove GCM Mock API in favor of integration tests Sep 27, 2022
@aabmass
Copy link
Collaborator Author

aabmass commented Nov 8, 2022

This is done for monitoring, would just need to dome something similar for trace.

@aabmass
Copy link
Collaborator Author

aabmass commented Feb 13, 2023

Triaged again, still low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant