Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-google-cloud-ops-agent-repo.sh pushes key to deprecated apt-key trusted.gpg keystore #1132

Open
sbconslt opened this issue Feb 27, 2023 · 3 comments
Labels
feature New feature or request

Comments

@sbconslt
Copy link

sbconslt commented Feb 27, 2023

add-google-cloud-ops-agent-repo.sh as currently delivered invokes apt-key add - to store the gpg key for package signing, which stores the key to /etc/apt/trusted.gpg, a deprecated procedure.

Newly on Ubuntu 22.04, the presence of this signing key in this location throws a deprecation Warning during apt-get update. This is a risk to the automated orchestration of updates. (apt-get update && apt-get dist-upgrade -y that we sometimes emplace, for example, is blocked by it as the first command appears to the shell to not exit 0.)

I produced the following diff of the change that relocates the signing key to its own file /etc/apt/trusted.gpg.d/google-cloud-ops-agent.gpg:

224c224
<         | ${DRY_RUN} apt-key add -
---
>         > /etc/apt/trusted.gpg.d/google-cloud-ops-agent.gpg

I do not locate the add-google-cloud-ops-agent-repo.sh file in this repository, though, so have not formed a PR.

Please consider updating the install scripting accordingly. Thanks.

@braydonk braydonk added the feature New feature or request label Mar 16, 2023
@braydonk
Copy link
Contributor

Hi @sbconslt, we have been tracking this internally and are working on it.

@kakugirai
Copy link

Hi @braydonk , is there any update on when we might expect to see progress on this feature?

@cjac
Copy link

cjac commented Aug 5, 2024

I was thinking I would take this one. can you assign to cjac, plz?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants