-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support private source maps #4
Comments
@steren I would like to support private source maps in stacktrace.js v2.0 and I want to design it in way that benefits this project. I'm curious if the intent is for source map files to be available publicly, though obscured by omitting the Thank you for using stacktrace.js, and please let me know if there are other changes I can make to my project to enable the Google Cloud Platform. |
Hi @eriwen, thanks for reaching out and thanks for your tremendous work on stacktracejs. I think the end goal should be for the source map file to never be accessible publicly. For Stackdriver Error Reporting, the ideal scenario would be the following:
However, today, none of these pieces (2,3,4) exist and they are not at the top of the priority list. The following scenario would be a good intermediate solution:
This scenario is achievable using the Stackdriver features that are available today. Some part of this Node.JS app are independent from Stackdriver Error Reporting, these could be the ones that make sense to be provided by What do you think? |
@steren Thanks very much for the kind words and the information — it makes a lot of sense. It seems like my best next step would be to spike a Node.JS app that does what you describe and see if any functionality in I'm happy to take this next step over the coming weeks. Do you think that'd be a beneficial investment for you? |
Any step (first of third party) that would bring users closer to private maps support is very valuable for us. We could keep the platform-agnostic part in stacktrace.js and the Stackdriver specific code in this repo (I would be glad to help you on this part). Keep me in the loop |
any updates? |
Today, I have no plans to work on this. |
I intend to focus on stacktrace.js v2.0 in the month of March, and will consider this. @steren are you still involved on this project given your new involvement with Bazel, or is there another I should work with if this is implemented? |
|
+1 |
I understand a lot of dedicated service providers out there provide some endpoints where clients publish release information and the accompanying source maps. Some of us may be using Cloud Build build and otherwise already have their build artifacts on Cloud Storage. So something that could also work on GCP is to provide the bucket URL to the source map. |
Another approach to this (used by Sentry.io for example) is to provide a token to stackdriver that will be used in a custom HTTP Header to authenticate stackdriver with the endpoint given in It seems a lot simpler to implement, what do you think? |
Any update / plan to support this ? |
1 similar comment
Any update / plan to support this ? |
The library only supports source maps when:
The minified file is appended with a comment directive to your source map file:
//# sourceMappingURL=http://example.com/path/to/your/sourcemap.map
And this file is publicly accessible.
Including server-side component, we could imagine a way to not need to make the source map available publicly.
The text was updated successfully, but these errors were encountered: