Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

ancestry_path is deprecated; use ancestors #105

Open
yukinying opened this issue Nov 20, 2019 · 1 comment
Open

ancestry_path is deprecated; use ancestors #105

yukinying opened this issue Nov 20, 2019 · 1 comment
Labels
Milestone

Comments

@yukinying
Copy link
Contributor

https://github.com/forseti-security/config-validator/blob/87b4ae546420814b2a6766a1b4569278f5e1627e/api/validator.proto#L44

  // Ancestor list as returned by CAI (added sometime around Oct 2019)
  repeated string ancestors = 6;

I have also verified that CAI now do not return ancestry_path. Instead it returns ancestors, which is a list of strings instead of a single string. For example,

		"ancestors": [
			"folders/12345",
			"organizations/67890"
		]

I think this will make the logic on generating ancestry be easier.

@melinath
Copy link
Member

It looks like config-validator uses ancestry_path internally and converts "ancestors" to a path if it's provided - however, I think this would make the expected structure more clear to users and it would be easier to change now than later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants