Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Auto-add generated converters to resource converter map #232

Open
melinath opened this issue Jun 22, 2021 · 1 comment
Open

Auto-add generated converters to resource converter map #232

melinath opened this issue Jun 22, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request tech debt

Comments

@melinath
Copy link
Member

melinath commented Jun 22, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave +1 or me too comments; they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If the issue is assigned to a user, that user is claiming responsibility for the issue.

Description

We currently already auto-generate conversion code for a bunch of resources that then have to be hand-added to terraform-validator. Building on the work for #217, we should also auto-add those converters to the resource converter map.

Note: because we don't want to mass-add resources without tests, we would need to add exclude_validator to the existing resources in the relevant terraform.yaml files for now. We can then re-enable them one by one as we're able to write tests.

@melinath melinath added enhancement New feature or request good first issue Good for newcomers tech debt and removed good first issue Good for newcomers labels Jun 22, 2021
@melinath melinath changed the title Auto-generate mappers for resource conversion Auto-add generated converters to resource converter map Nov 17, 2021
@marktru
Copy link

marktru commented Dec 23, 2021

Internal issue: b/211888856

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request tech debt
Projects
None yet
Development

No branches or pull requests

3 participants