Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Add support for --include-unchanged flag to convert and validate commands #282

Open
melinath opened this issue Aug 4, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@melinath
Copy link
Member

melinath commented Aug 4, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave +1 or me too comments; they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If the issue is assigned to a user, that user is claiming responsibility for the issue.

Description

We have the ability to validate existing resources, but by default we only validate resources that are being created, updated, or deleted. It might be nice to have a command-line flag that lets people also validate existing resources.

This flag could be called --include-unchanged or similar.

References

@melinath melinath added enhancement New feature or request good first issue Good for newcomers labels Aug 4, 2021
@jralmaraz
Copy link

Hi @melinath , I am looking forward to try and contribute with the repo. Is there any recommended read for a good first issue like this ? Thanks!

@melinath
Copy link
Member Author

melinath commented Aug 5, 2021

For this particular issue I would recommend looking at the https://github.com/GoogleCloudPlatform/terraform-validator/tree/main/cmd directory - there are a number of similar flags that you could base off of. TFV commands are implemented using github.com/spf13/cobra

@jralmaraz
Copy link

thanks so much for the pointers @melinath , I'll find some time to look into that and have a crack, cheers!

@melinath melinath removed the good first issue Good for newcomers label Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants